Swift: Update swift/sql-injection to include local flow sources.

geoffw0 · geoffw0 · commit b3d2e759a6b6 · 2022-11-28T10:11:44.000Z
diff --git a/swift/ql/src/queries/Security/CWE-089/SqlInjection.ql b/swift/ql/src/queries/Security/CWE-089/SqlInjection.ql
@@ -69,7 +69,7 @@ class SQLiteSwiftSqlSink extends SqlSink {
 class SqlInjectionConfig extends TaintTracking::Configuration {
   SqlInjectionConfig() { this = "SqlInjectionConfig" }
 
-  override predicate isSource(DataFlow::Node node) { node instanceof RemoteFlowSource }
+  override predicate isSource(DataFlow::Node node) { node instanceof FlowSource }
 
   override predicate isSink(DataFlow::Node node) { node instanceof SqlSink }
 }

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ class SQLiteSwiftSqlSink extends SqlSink {`
`69`	`69`	`class SqlInjectionConfig extends TaintTracking::Configuration {`
`70`	`70`	`SqlInjectionConfig() { this = "SqlInjectionConfig" }`
`71`	`71`
`72`		`- override predicate isSource(DataFlow::Node node) { node instanceof RemoteFlowSource }`
	`72`	`+ override predicate isSource(DataFlow::Node node) { node instanceof FlowSource }`
`73`	`73`
`74`	`74`	`override predicate isSink(DataFlow::Node node) { node instanceof SqlSink }`
`75`	`75`	`}`