Skip to content

Commit b3d8c6b

Browse files
committed
Add error handling to test
1 parent 60cf1ec commit b3d8c6b

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

go/ql/test/library-tests/semmle/go/dataflow/flowsources/local/database/test_database_sql.go

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ func testConnQuery(conn *sql.Conn) {
1818
var id int
1919
var name string
2020
err = rows.Scan(&id, &name)
21+
if err != nil {
22+
return
23+
}
2124

2225
sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
2326
}
@@ -50,6 +53,10 @@ func testDBQuery(db *sql.DB) {
5053
var name string
5154
err = rows.Scan(&id, &name)
5255

56+
if err != nil {
57+
return
58+
}
59+
5360
sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
5461
}
5562

@@ -84,6 +91,10 @@ func testStmtQuery(stmt *sql.Stmt) {
8491
var name string
8592
err = rows.Scan(&id, &name)
8693

94+
if err != nil {
95+
return
96+
}
97+
8798
sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
8899
}
89100

@@ -94,6 +105,10 @@ func testStmtQuery(stmt *sql.Stmt) {
94105

95106
err = row.Scan(&id, &name)
96107

108+
if err != nil {
109+
return
110+
}
111+
97112
sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
98113

99114
dog := stmt.QueryRow("SELECT * FROM dogs WHERE id = 1") // $ source
@@ -117,6 +132,10 @@ func testTxQuery(tx *sql.Tx) {
117132
var name string
118133
err = rows.Scan(&id, &name)
119134

135+
if err != nil {
136+
return
137+
}
138+
120139
sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
121140
}
122141

@@ -127,6 +146,10 @@ func testTxQuery(tx *sql.Tx) {
127146

128147
err = row.Scan(&id, &name)
129148

149+
if err != nil {
150+
return
151+
}
152+
130153
sink(id, name) // $ hasTaintFlow="id" hasTaintFlow="name"
131154

132155
dog := tx.QueryRow("SELECT * FROM dogs WHERE id = 1") // $ source

0 commit comments

Comments
 (0)