Ruby: Only model relevant files for type models

koesie10 · koesie10 · commit b51379b533c1 · 2024-01-31T11:30:16.000+01:00
diff --git a/ruby/ql/src/queries/modeling/internal/Types.qll b/ruby/ql/src/queries/modeling/internal/Types.qll
@@ -48,7 +48,11 @@ module Types {
     // class Type2 < Type1
     // class Type2; include Type1
     exists(Module m1, Module m2 |
-      m2.getAnImmediateAncestor() = m1 and not m2.isBuiltin() and not m1.isBuiltin()
+      m2.getAnImmediateAncestor() = m1 and
+      not m2.isBuiltin() and
+      not m1.isBuiltin() and
+      m1.getLocation().getFile() instanceof Util::RelevantFile and
+      m2.getLocation().getFile() instanceof Util::RelevantFile
     |
       m1.getQualifiedName() = type1 and m2.getQualifiedName() = type2 and path = ""
     )

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,11 @@ module Types {`
`48`	`48`	`// class Type2 < Type1`
`49`	`49`	`// class Type2; include Type1`
`50`	`50`	`exists(Module m1, Module m2 \|`
`51`		`- m2.getAnImmediateAncestor() = m1 and not m2.isBuiltin() and not m1.isBuiltin()`
	`51`	`+ m2.getAnImmediateAncestor() = m1 and`
	`52`	`+ not m2.isBuiltin() and`
	`53`	`+ not m1.isBuiltin() and`
	`54`	`+ m1.getLocation().getFile() instanceof Util::RelevantFile and`
	`55`	`+ m2.getLocation().getFile() instanceof Util::RelevantFile`
`52`	`56`	`\|`
`53`	`57`	`m1.getQualifiedName() = type1 and m2.getQualifiedName() = type2 and path = ""`
`54`	`58`	`)`