Skip to content

Commit b54de13

Browse files
RasmusWLtausbn
andauthored
Python: Apply suggestions from code review
Co-authored-by: Taus <[email protected]>
1 parent 044829c commit b54de13

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

python/ql/src/Security/CWE-285/PamAuthorization.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
A
1111
<code>pam_authenticate</code>
1212
only verifies the credentials of a user. It does not check if a user has an
13-
appropriate authorization to actually login. This means a user with a expired
13+
appropriate authorization to actually login. This means a user with an expired
1414
login or a password can still access the system.
1515
</p>
1616

@@ -29,7 +29,7 @@
2929
<example>
3030
<p>
3131
In the following example, the code only checks the credentials of a user. Hence,
32-
in this case, a user expired with expired creds can still login. This can be
32+
in this case, a user with expired credentials can still login. This can be
3333
verified by creating a new user account, expiring it with
3434
<code>chage -E0 `username` </code>
3535
and then trying to log in.

python/ql/src/Security/CWE-285/PamAuthorization.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ where
3535
DataFlow::localFlow(handle, acctMgmtCall.getArg(0))
3636
)
3737
select authenticateCall,
38-
"This PAM authentication call may be lead to an authorization bypass, since 'pam_acct_mgmt' is not called afterwards."
38+
"This PAM authentication call may lead to an authorization bypass, since 'pam_acct_mgmt' is not called afterwards."
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
| pam_test.py:48:18:48:44 | ControlFlowNode for pam_authenticate() | This PAM authentication call may be lead to an authorization bypass, since 'pam_acct_mgmt' is not called afterwards. |
1+
| pam_test.py:48:18:48:44 | ControlFlowNode for pam_authenticate() | This PAM authentication call may lead to an authorization bypass, since 'pam_acct_mgmt' is not called afterwards. |

0 commit comments

Comments
 (0)