Swift: include null terminators into the invocation file hash

AlexDenisov · AlexDenisov · commit b62a4aae1a02 · 2022-11-08T14:36:28.000+01:00
diff --git a/swift/extractor/main.cpp b/swift/extractor/main.cpp
@@ -109,7 +109,7 @@ static void checkWhetherToRunUnderTool(int argc, char* const* argv) {
 codeql::TargetFile invocationTargetFile(codeql::SwiftExtractorConfiguration& configuration) {
   auto hasher = picosha2::hash256_one_by_one();
   for (auto& option : configuration.frontendOptions) {
-    hasher.process(std::begin(option), std::end(option));
+    hasher.process(option.c_str(), option.c_str() + option.size() + 1);
   }
   hasher.finish();
   auto target = "invocation-"s + get_hash_hex_string(hasher);

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ static void checkWhetherToRunUnderTool(int argc, char* const* argv) {`
`109`	`109`	`codeql::TargetFile invocationTargetFile(codeql::SwiftExtractorConfiguration& configuration) {`
`110`	`110`	`auto hasher = picosha2::hash256_one_by_one();`
`111`	`111`	`for (auto& option : configuration.frontendOptions) {`
`112`		`- hasher.process(std::begin(option), std::end(option));`
	`112`	`+ hasher.process(option.c_str(), option.c_str() + option.size() + 1);`
`113`	`113`	`}`
`114`	`114`	`hasher.finish();`
`115`	`115`	`auto target = "invocation-"s + get_hash_hex_string(hasher);`