Skip to content

Commit bada986

Browse files
Jami CogswellJami Cogswell
authored andcommitted
apply review comments
1 parent b99a1d2 commit bada986

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

java/ql/lib/semmle/code/java/security/regexp/RegexInjection.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,10 @@ private class PatternQuoteCall extends RegexInjectionSanitizer {
4040
*/
4141
private class PatternLiteralFlag extends RegexInjectionSanitizer {
4242
PatternLiteralFlag() {
43-
exists(MethodAccess ma, Method m, Field field | m = ma.getMethod() |
43+
exists(MethodAccess ma, Method m, PatternLiteralField field | m = ma.getMethod() |
4444
ma.getArgument(0) = this.asExpr() and
4545
m.getDeclaringType() instanceof TypeRegexPattern and
4646
m.hasName("compile") and
47-
field instanceof PatternLiteralField and
4847
ma.getArgument(1) = field.getAnAccess()
4948
)
5049
}

java/ql/test/query-tests/security/CWE-730/RegexInjectionTest.ql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import java
22
import TestUtilities.InlineExpectationsTest
33
import semmle.code.java.security.regexp.RegexInjectionQuery
44

5-
//import semmle.code.java.security.regexp.PolynomialReDoSQuery
65
class RegexInjectionTest extends InlineExpectationsTest {
76
RegexInjectionTest() { this = "RegexInjectionTest" }
87

0 commit comments

Comments
 (0)