File tree Expand file tree Collapse file tree 1 file changed +8
-0
lines changed
python/ql/lib/semmle/python/dataflow/new/internal Expand file tree Collapse file tree 1 file changed +8
-0
lines changed Original file line number Diff line number Diff line change @@ -5,6 +5,11 @@ private import DataFlowPublic
5
5
private import semmle.python.dataflow.new.internal.DataFlowPrivate
6
6
private import codeql.dataflow.VariableCapture as Shared
7
7
8
+ // Note: The Javascript implementation (on the branch https://github.com/github/codeql/pull/14412)
9
+ // had some tweaks related to performance. See these two commits:
10
+ // - JS: Capture flow: https://github.com/github/codeql/pull/14412/commits/7bcf8b858babfea0a3e36ce61145954c249e13ac
11
+ // - JS: Disallow consecutive captured contents: https://github.com/github/codeql/pull/14412/commits/46e4cdc6232604ea7f58138a336d5a222fad8567
12
+ // The first is the main implementation, the second is a performance motivated restriction.
8
13
private module CaptureInput implements Shared:: InputSig< Location > {
9
14
private import python as PY
10
15
@@ -142,6 +147,9 @@ predicate valueStep(Node nodeFrom, Node nodeTo) {
142
147
/**
143
148
* Provides predicates to understand the behaviour of the variable capture
144
149
* library instantiation on Python code bases.
150
+ *
151
+ * The predicates in here are meant to be run by quick-eval on databases of
152
+ * interest. The `unmapped*`-predicates should ideally be empty.
145
153
*/
146
154
private module Debug {
147
155
predicate flowStoreStep (
You can’t perform that action at this time.
0 commit comments