Skip to content

Commit c0c71c5

Browse files
jorgectfyoff
andcommitted
Apply suggestions from code review
Update `RegexExecution` docs and use `flowsTo()` instead of `getALocalSource()`. Co-authored-by: yoff <[email protected]>
1 parent c432284 commit c0c71c5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

python/ql/src/experimental/semmle/python/Concepts.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ private import experimental.semmle.python.Frameworks
1717
/** Provides classes for modeling Regular Expression-related APIs. */
1818
module RegexExecution {
1919
/**
20-
* A data-flow node that collects methods immediately executing an expression.
20+
* A data-flow node that executes a regular expression.
2121
*
2222
* Extend this class to model new APIs. If you want to refine existing API models,
2323
* extend `RegexExecution` instead.

python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ private module Re {
6060
exists(DataFlow::CallCfgNode patternCall, DataFlow::AttrRead reMethod |
6161
this.getFunction() = reMethod and
6262
patternCall = API::moduleImport("re").getMember("compile").getACall() and
63-
patternCall = reMethod.getObject().getALocalSource() and
63+
patternCall.flowsTo(reMethod.getObject()) and
6464
reMethod.getAttributeName() instanceof RegexExecutionMethods and
6565
regexNode = patternCall.getArg(0)
6666
)

0 commit comments

Comments
 (0)