Skip to content

Commit c1ab49f

Browse files
committed
rename LDapFilterStep to TaintPreservingLDapFilterStep
1 parent 5a1eb19 commit c1ab49f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

javascript/ql/lib/semmle/javascript/frameworks/LDAPjs.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ module LDAPjs {
3535
}
3636

3737
/** A creation of an LDAPjs filter, or object containing a filter, that doesn't sanitizes the input. */
38-
abstract class LDAPFilterStep extends DataFlow::Node {
38+
abstract class TaintPreservingLdapFilterStep extends DataFlow::Node {
3939
/** The input that creates (part of) an LDAPjs filter. */
4040
abstract DataFlow::Node getInput();
4141

@@ -44,7 +44,7 @@ module LDAPjs {
4444
}
4545

4646
/** A call to the ldap utility method "parseFilter". */
47-
private class ParseFilter extends LDAPFilterStep, API::CallNode {
47+
private class ParseFilter extends TaintPreservingLdapFilterStep, API::CallNode {
4848
ParseFilter() { this = ldapjs().getMember("parseFilter").getACall() }
4949

5050
override DataFlow::Node getInput() { result = this.getArgument(0) }
@@ -56,7 +56,7 @@ module LDAPjs {
5656
* A filter used in call to "search" on an LDAPjs client.
5757
* We model that as a step from the ".filter" write to the options object itself.
5858
*/
59-
private class SearchFilter extends LDAPFilterStep {
59+
private class SearchFilter extends TaintPreservingLdapFilterStep {
6060
SearchOptions options;
6161

6262
SearchFilter() {

javascript/ql/lib/semmle/javascript/security/dataflow/SqlInjectionQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class Configuration extends TaintTracking::Configuration {
2626
}
2727

2828
override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
29-
exists(LDAPjs::LDAPFilterStep filter |
29+
exists(LDAPjs::TaintPreservingLdapFilterStep filter |
3030
pred = filter.getInput() and
3131
succ = filter.getOutput()
3232
)

0 commit comments

Comments
 (0)