Merge pull request #5532 from RasmusWL/python-cleanup

Python: Delete filter queries, code duplication library, and precision tag from metric queries

Author: calumgrant

python/change-notes/2021-03-25-remove-legacy.md

@@ -0,0 +1,3 @@
+lgtm,codescanning
+* The legacy code duplication library has been removed.
+* Legacy filter queries have been removed.

python/ql/src/Filters/NotGenerated.ql

@@ -4,7 +4,6 @@
  * @kind treemap
  * @treemap.warnOn highValues
  * @metricType file
- * @precision high
  * @tags maintainability
  * @id py/lines-of-commented-out-code-in-files
  */

python/ql/src/Filters/NotTest.ql

@@ -5,7 +5,6 @@
  * @kind treemap
  * @treemap.warnOn highValues
  * @metricType externalDependency
- * @precision medium
  * @id py/external-dependencies
  */
 

python/ql/src/Lexical/FCommentedOutCode.ql

@@ -6,7 +6,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @tags maintainability
  * @id py/lines-of-code-in-files
  */

python/ql/src/Metrics/Dependencies/ExternalDependencies.ql

@@ -6,7 +6,6 @@
  * @treemap.warnOn lowValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id py/lines-of-comments-in-files
  */
 

python/ql/src/Metrics/FLinesOfCode.ql

@@ -7,21 +7,12 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision high
  * @tags testability
  * @id py/duplicated-lines-in-files
  */
 
 import python
-import external.CodeDuplication
 
 from File f, int n
-where
-  n =
-    count(int line |
-      exists(DuplicateBlock d | d.sourceFile() = f |
-        line in [d.sourceStartLine() .. d.sourceEndLine()] and
-        not allowlistedLineForDuplication(f, line)
-      )
-    )
+where none()
 select f, n order by n desc

python/ql/src/Metrics/FLinesOfComments.ql

@@ -7,21 +7,12 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision high
  * @tags testability
  * @id py/similar-lines-in-files
  */
 
 import python
-import external.CodeDuplication
 
 from File f, int n
-where
-  n =
-    count(int line |
-      exists(SimilarBlock d | d.sourceFile() = f |
-        line in [d.sourceStartLine() .. d.sourceEndLine()] and
-        not allowlistedLineForDuplication(f, line)
-      )
-    )
+where none()
 select f, n order by n desc

python/ql/src/Metrics/FLinesOfDuplicatedCode.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn lowValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision medium
  * @id py/tests-in-files
  */