Skip to content

Commit c4b0955

Browse files
committed
Java: convert WebviewDebuggingEnabled test to .qlref
1 parent 192f45e commit c4b0955

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

java/ql/test/query-tests/security/CWE-489/webview-debugging/Test.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ class Test {
44
boolean DEBUG_BUILD;
55

66
void test1() {
7-
WebView.setWebContentsDebuggingEnabled(true); // $hasValueFlow
7+
WebView.setWebContentsDebuggingEnabled(true); // $ Alert
88
}
99

1010
void test2(){
1111
if (DEBUG_BUILD) {
12-
WebView.setWebContentsDebuggingEnabled(true);
12+
WebView.setWebContentsDebuggingEnabled(true);
1313
}
1414
}
1515

1616
void test3(boolean enabled){
17-
WebView.setWebContentsDebuggingEnabled(enabled); // $hasValueFlow
17+
WebView.setWebContentsDebuggingEnabled(enabled); // $ Alert
1818
}
1919

2020
void test4(){
21-
test3(true);
21+
test3(true); // $ Source
2222
}
23-
}
23+
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#select
2+
| Test.java:7:48:7:51 | true | Test.java:7:48:7:51 | true | Test.java:7:48:7:51 | true | Webview debugging is enabled. |
3+
| Test.java:17:48:17:54 | enabled | Test.java:21:15:21:18 | true : Boolean | Test.java:17:48:17:54 | enabled | Webview debugging is enabled. |
4+
edges
5+
| Test.java:16:16:16:30 | enabled : Boolean | Test.java:17:48:17:54 | enabled | provenance | |
6+
| Test.java:21:15:21:18 | true : Boolean | Test.java:16:16:16:30 | enabled : Boolean | provenance | |
7+
nodes
8+
| Test.java:7:48:7:51 | true | semmle.label | true |
9+
| Test.java:16:16:16:30 | enabled : Boolean | semmle.label | enabled : Boolean |
10+
| Test.java:17:48:17:54 | enabled | semmle.label | enabled |
11+
| Test.java:21:15:21:18 | true : Boolean | semmle.label | true : Boolean |
12+
subpaths

java/ql/test/query-tests/security/CWE-489/webview-debugging/WebviewDebuggingEnabled.ql

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
query: Security/CWE/CWE-489/WebviewDebuggingEnabled.ql
2+
postprocess:
3+
- utils/test/PrettyPrintModels.ql
4+
- utils/test/InlineExpectationsTestQuery.ql

0 commit comments

Comments
 (0)