Rust: Jump-to-def for operations and indexing

Author: hvitved

rust/ql/lib/codeql/rust/internal/Definitions.qll

@@ -26,6 +26,19 @@ abstract class Use extends Locatable {
    * Gets the type of use.
    */
   abstract string getUseType();
+
+  /**
+   * Holds if this element is at the specified location.
+   * The location spans column `startcolumn` of line `startline` to
+   * column `endcolumn` of line `endline` in file `filepath`.
+   * For more information, see
+   * [Providing locations in CodeQL queries](https://codeql.github.com/docs/writing-codeql-queries/providing-locations-in-codeql-queries/).
+   */
+  predicate hasLocationInfo(
+    string filepath, int startline, int startcolumn, int endline, int endcolumn
+  ) {
+    this.getLocation().hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn)
+  }
 }
 
 cached
@@ -166,6 +179,43 @@ private class MethodUse extends Use instanceof NameRef {
   override string getUseType() { result = "method" }
 }
 
+private class OperationUse extends Use instanceof Operation {
+  override Definition getDefinition() { result.asItemNode() = this.(Call).getStaticTarget() }
+
+  override string getUseType() { result = "method" }
+
+  override predicate hasLocationInfo(
+    string filepath, int startline, int startcolumn, int endline, int endcolumn
+  ) {
+    // We don't have entities for the operator symbols, so approximate a location
+    this =
+      any(PrefixExpr pe |
+        pe.getLocation().hasLocationInfo(filepath, startline, startcolumn, _, _) and
+        pe.getExpr().getLocation().hasLocationInfo(_, endline, endcolumn + 2, _, _)
+      )
+    or
+    this =
+      any(BinaryExpr be |
+        be.getLhs().getLocation().hasLocationInfo(filepath, _, _, startline, startcolumn - 2) and
+        be.getRhs().getLocation().hasLocationInfo(filepath, endline, endcolumn + 2, _, _)
+      )
+  }
+}
+
+private class IndexExprUse extends Use instanceof IndexExpr {
+  override Definition getDefinition() { result.asItemNode() = this.(Call).getStaticTarget() }
+
+  override string getUseType() { result = "method" }
+
+  override predicate hasLocationInfo(
+    string filepath, int startline, int startcolumn, int endline, int endcolumn
+  ) {
+    // We don't have entities for the brackets, so approximate a location
+    super.getIndex().getLocation().hasLocationInfo(filepath, _, _, startline, startcolumn - 2) and
+    this.getLocation().hasLocationInfo(_, _, _, endline, endcolumn)
+  }
+}
+
 private class FileUse extends Use instanceof Name {
   override Definition getDefinition() {
     exists(Module m |

rust/ql/test/library-tests/definitions/Definitions.expected

@@ -68,7 +68,10 @@
 | main.rs:66:14:66:14 | S | main.rs:3:1:4:9 | struct S | path |
 | main.rs:66:18:66:20 | new | main.rs:46:9:48:9 | fn new | path |
 | main.rs:66:22:66:22 | S | main.rs:3:1:4:9 | struct S | path |
+| main.rs:67:5:67:4 | - ... | main.rs:11:5:13:5 | fn neg | method |
 | main.rs:67:6:67:6 | S | main.rs:3:1:4:9 | struct S | path |
 | main.rs:68:5:68:5 | S | main.rs:3:1:4:9 | struct S | path |
+| main.rs:68:7:68:7 | ... + ... | main.rs:19:5:21:5 | fn add | method |
 | main.rs:68:9:68:9 | S | main.rs:3:1:4:9 | struct S | path |
 | main.rs:69:5:69:5 | S | main.rs:3:1:4:9 | struct S | path |
+| main.rs:69:9:69:8 | S[0] | main.rs:27:5:29:5 | fn index | method |