QL: fix visibility of module parameters

aibaars · aibaars · commit c8255770bcf6 · 2022-12-20T11:22:20.000+01:00
diff --git a/ql/ql/src/codeql_ql/ast/internal/Type.qll b/ql/ql/src/codeql_ql/ast/internal/Type.qll
@@ -387,7 +387,7 @@ private predicate defines(FileOrModule m, string name, Type t, boolean public) {
   exists(Module mod, SignatureExpr param, int i |
     m.asModule() = mod and
     mod.hasParameter(i, name, param) and
-    public = true
+    public = false
   |
     // resolve to the signature class
     t = param.asType().getResolvedType()

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,7 @@ private predicate defines(FileOrModule m, string name, Type t, boolean public) {`
`387`	`387`	`exists(Module mod, SignatureExpr param, int i \|`
`388`	`388`	`m.asModule() = mod and`
`389`	`389`	`mod.hasParameter(i, name, param) and`
`390`		`- public = true`
	`390`	`+ public = false`
`391`	`391`	`\|`
`392`	`392`	`// resolve to the signature class`
`393`	`393`	`t = param.asType().getResolvedType()`