Skip to content

Commit c89178c

Browse files
Apply suggestions from code review
Co-authored-by: Tony Torralba <[email protected]>
1 parent 2d368a7 commit c89178c

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
lgtm,codescanning
2-
* The query "Broadcasting sensitive data to all Android applications" (`java/android/sensitive-broadcast`) has been promoted from experimental the main query pack. Its results will now appear by default. The query was originally [submitted as an experimental query by @luchua-bc.](https://github.com/github/codeql/pull/4512)
2+
* The query "Leaking sensitive information through an implicit Intent" (`java/android/sensitive-communication`) has been promoted from experimental to the main query pack. Its results will now appear by default. The query was originally [submitted as an experimental query by @luchua-bc.](https://github.com/github/codeql/pull/4512)

java/ql/src/Security/CWE/CWE-927/SensitiveCommunication.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<recommendation>
1010
<p>
11-
For <code>sendBroadcast</code> methods, a receiver permission may be specified so that only applications with a certain permission may read recieve the intent;
11+
For <code>sendBroadcast</code> methods, a receiver permission may be specified so that only applications with a certain permission may receive the intent;
1212
or a <code>LocalBroadcastManager</code> may be used.
1313
Otherwise, ensure that intents containing sensitive data have an explicit receiver class set.
1414
</p>

java/ql/src/Security/CWE/CWE-927/SensitiveCommunication.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
/**
2-
* @name Leaking sensetive information through an implicit Intent.
2+
* @name Leaking sensitive information through an implicit Intent
33
* @description An Android application uses implicit intents containing sensitive data
44
* in a way that exposes it to arbitrary applications on the device.
55
* @kind path-problem
66
* @problem.severity warning
7+
* @security-severity 8.2
78
* @precision medium
89
* @id java/android/sensitive-communication
910
* @tags security

0 commit comments

Comments
 (0)