Skip to content

Commit cec124c

Browse files
authored
Merge pull request #15480 from ockers/ockers/certification_not_certificate
False positive in SensitiveDataHeuristics - exclude certification from maybeCertificate() regex
2 parents 525f271 + 01e8109 commit cec124c

File tree

8 files changed

+20
-4
lines changed

8 files changed

+20
-4
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* The name "certification" is no longer seen as possibly being a certificate, and will therefore no longer be flagged in queries like "clear-text-logging" which look for sensitive data.

javascript/ql/lib/semmle/javascript/security/internal/SensitiveDataHeuristics.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ module HeuristicNames {
7575
* Gets a regular expression that identifies strings that may indicate the presence of
7676
* a certificate.
7777
*/
78-
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name)).*" }
78+
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name|ification)).*" }
7979

8080
/**
8181
* Gets a regular expression that identifies strings that may indicate the presence
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* The name "certification" is no longer seen as possibly being a certificate, and will therefore no longer be flagged in queries like "clear-text-logging" which look for sensitive data.

python/ql/lib/semmle/python/security/internal/SensitiveDataHeuristics.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ module HeuristicNames {
7575
* Gets a regular expression that identifies strings that may indicate the presence of
7676
* a certificate.
7777
*/
78-
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name)).*" }
78+
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name|ification)).*" }
7979

8080
/**
8181
* Gets a regular expression that identifies strings that may indicate the presence
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* The name "certification" is no longer seen as possibly being a certificate, and will therefore no longer be flagged in queries like "clear-text-logging" which look for sensitive data.

ruby/ql/lib/codeql/ruby/security/internal/SensitiveDataHeuristics.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ module HeuristicNames {
7575
* Gets a regular expression that identifies strings that may indicate the presence of
7676
* a certificate.
7777
*/
78-
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name)).*" }
78+
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name|ification)).*" }
7979

8080
/**
8181
* Gets a regular expression that identifies strings that may indicate the presence
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* The name "certification" is no longer seen as possibly being a certificate, and will therefore no longer be flagged in queries like "clear-text-logging" which look for sensitive data.

swift/ql/lib/codeql/swift/security/internal/SensitiveDataHeuristics.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ module HeuristicNames {
7575
* Gets a regular expression that identifies strings that may indicate the presence of
7676
* a certificate.
7777
*/
78-
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name)).*" }
78+
string maybeCertificate() { result = "(?is).*(cert)(?!.*(format|name|ification)).*" }
7979

8080
/**
8181
* Gets a regular expression that identifies strings that may indicate the presence

0 commit comments

Comments
 (0)