Skip to content

Commit cfd2dcf

Browse files
committed
recognize more modelled database accesses
1 parent b0f6cf1 commit cfd2dcf

File tree

1 file changed

+3
-2
lines changed
  • javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling

1 file changed

+3
-2
lines changed

javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/CoreKnowledge.qll

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,9 @@ predicate isOtherModeledArgument(DataFlow::Node n, FilteringReason reason) {
200200
or
201201
call instanceof FileSystemAccess and reason instanceof FileSystemAccessReason
202202
or
203-
// TODO database accesses are less well defined than database query sinks, so this may cover unmodeled sinks
204-
call instanceof DatabaseAccess and reason instanceof DatabaseAccessReason
203+
// TODO database accesses are less well defined than database query sinks, so this may cover unmodeled sinks on existing database models
204+
[call, call.getAMethodCall() /* command pattern where the query is built, and then exec'ed later */] instanceof DatabaseAccess and
205+
reason instanceof DatabaseAccessReason
205206
or
206207
call = DOM::domValueRef() and reason instanceof DOMReason
207208
or

0 commit comments

Comments
 (0)