Skip to content

Commit d00e279

Browse files
committed
C#: No longer consider attribute collections as HTML sinks.
1 parent 28c48fb commit d00e279

File tree

1 file changed

+2
-4
lines changed
  • csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsinks

1 file changed

+2
-4
lines changed

csharp/ql/lib/semmle/code/csharp/security/dataflow/flowsinks/Html.qll

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,11 @@ class HtmlTextWriterSink extends HtmlSink {
5656
}
5757

5858
/**
59-
* An expression that is used as an argument to an HTML sink method on
60-
* `AttributeCollection`.
59+
* DEPRECATED: Attribute collections are no longer considered HTML sinks.
6160
*/
62-
class AttributeCollectionSink extends HtmlSink {
61+
deprecated class AttributeCollectionSink extends DataFlow::ExprNode {
6362
AttributeCollectionSink() {
6463
exists(SystemWebUIAttributeCollectionClass ac, Parameter p |
65-
p = ac.getAddMethod().getParameter(1) or
6664
p = ac.getItemProperty().getSetter().getParameter(0)
6765
|
6866
this.getExpr() = p.getAnAssignedArgument()

0 commit comments

Comments
 (0)