always get a good join-order in getAnAliasedSourceNode

erik-krogh · erik-krogh · commit d35ea7fb1575 · 2021-02-25T11:41:08.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll b/javascript/ql/src/semmle/javascript/GlobalAccessPaths.qll
@@ -415,7 +415,7 @@ module AccessPath {
   pragma[inline]
   DataFlow::SourceNode getAnAliasedSourceNode(DataFlow::Node node) {
     exists(DataFlow::SourceNode root, string accessPath |
-      node = AccessPath::getAReferenceTo(root, accessPath) and
+      node = pragma[only_bind_into](AccessPath::getAReferenceTo(root, accessPath)) and
       result = AccessPath::getAReferenceTo(root, accessPath)
     )
     or

Original file line number	Diff line number	Diff line change
`@@ -415,7 +415,7 @@ module AccessPath {`
`415`	`415`	`pragma[inline]`
`416`	`416`	`DataFlow::SourceNode getAnAliasedSourceNode(DataFlow::Node node) {`
`417`	`417`	`exists(DataFlow::SourceNode root, string accessPath \|`
`418`		`- node = AccessPath::getAReferenceTo(root, accessPath) and`
	`418`	`+ node = pragma[only_bind_into](AccessPath::getAReferenceTo(root, accessPath)) and`
`419`	`419`	`result = AccessPath::getAReferenceTo(root, accessPath)`
`420`	`420`	`)`
`421`	`421`	`or`