Skip to content

Commit d4f3a6d

Browse files
committed
C#: Review comments. Keep the TContent type pribate
1 parent b9d0a60 commit d4f3a6d

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

java/ql/lib/semmle/code/java/dataflow/internal/DataFlowUtil.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ predicate simpleLocalFlowStep(Node node1, Node node2) {
164164
pragma[only_bind_out](node2.getEnclosingCallable())
165165
}
166166

167-
newtype TContent =
167+
private newtype TContent =
168168
TFieldContent(InstanceField f) or
169169
TArrayContent() or
170170
TCollectionContent() or

java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImplSpecific.qll

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,14 @@ SummaryComponent interpretComponentSpecific(string c) {
7575
/** Gets the summary component for specification component `c`, if any. */
7676
private string getContentSpecificCsv(Content c) {
7777
exists(Field f, string package, string className, string fieldName |
78-
c = TFieldContent(f) and
78+
f = c.(FieldContent).getField() and
7979
f.hasQualifiedName(package, className, fieldName) and
8080
result = "Field[" + package + "." + className + "." + fieldName + "]"
8181
)
8282
or
83-
exists(SyntheticField f | c = TSyntheticFieldContent(f) and result = "SyntheticField[" + f + "]")
83+
exists(SyntheticField f |
84+
f = c.(SyntheticFieldContent).getField() and result = "SyntheticField[" + f + "]"
85+
)
8486
or
8587
c instanceof ArrayContent and result = "ArrayElement"
8688
or

0 commit comments

Comments
 (0)