Skip to content

Commit d588ee3

Browse files
committed
Fix mayHaveSideEffects for ReturnStmt
The previous code only worked when the return statement only has one returned expression.
1 parent 2c50014 commit d588ee3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

go/ql/lib/semmle/go/Stmt.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ class ReturnStmt extends @returnstmt, Stmt {
569569
/** Gets the unique returned expression, if there is only one. */
570570
Expr getExpr() { getNumChild() = 1 and result = getExpr(0) }
571571

572-
override predicate mayHaveSideEffects() { getExpr().mayHaveSideEffects() }
572+
override predicate mayHaveSideEffects() { getAnExpr().mayHaveSideEffects() }
573573

574574
override string toString() { result = "return statement" }
575575

0 commit comments

Comments
 (0)