Skip to content

Commit d83500d

Browse files
committed
Address review comments
1 parent 6c0ed28 commit d83500d

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3932,6 +3932,8 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
39323932
override predicate isSource() { none() }
39333933

39343934
override string toString() { result = sourceGroup }
3935+
3936+
override Location getLocation() { result.hasLocationInfo("", 0, 0, 0, 0) }
39353937
}
39363938

39373939
private class PathNodeSinkGroup extends PathNodeImpl, TPathNodeSinkGroup {
@@ -3948,6 +3950,8 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
39483950
override predicate isSource() { none() }
39493951

39503952
override string toString() { result = sinkGroup }
3953+
3954+
override Location getLocation() { result.hasLocationInfo("", 0, 0, 0, 0) }
39513955
}
39523956

39533957
private predicate pathNode(

shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1650,8 +1650,6 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
16501650
*/
16511651
class CastingNode extends NodeFinal {
16521652
CastingNode() { castingNode(this) }
1653-
1654-
string toString() { result = super.toString() }
16551653
}
16561654

16571655
private predicate readStepWithTypes(
@@ -1800,8 +1798,6 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
18001798
class ParamNode extends NodeFinal {
18011799
ParamNode() { parameterNode(this, _, _) }
18021800

1803-
string toString() { result = super.toString() }
1804-
18051801
/**
18061802
* Holds if this node is the parameter of callable `c` at the specified
18071803
* position.
@@ -1815,8 +1811,6 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
18151811
class ArgNode extends NodeFinal {
18161812
ArgNode() { argumentNode(this, _, _) }
18171813

1818-
string toString() { result = super.toString() }
1819-
18201814
/** Holds if this argument occurs at the given position in the given call. */
18211815
final predicate argumentOf(DataFlowCall call, ArgumentPosition pos) {
18221816
argumentNode(this, call, pos)
@@ -1830,8 +1824,6 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
18301824
class ReturnNodeExt extends NodeFinal {
18311825
ReturnNodeExt() { returnNodeExt(this, _) }
18321826

1833-
string toString() { result = super.toString() }
1834-
18351827
/** Gets the kind of this returned value. */
18361828
ReturnKindExt getKind() { returnNodeExt(this, result) }
18371829
}
@@ -1842,8 +1834,6 @@ module MakeImplCommon<LocationSig Location, InputSig<Location> Lang> {
18421834
*/
18431835
class OutNodeExt extends NodeFinal {
18441836
OutNodeExt() { outNodeExt(this) }
1845-
1846-
string toString() { result = super.toString() }
18471837
}
18481838

18491839
/**

0 commit comments

Comments
 (0)