Skip to content

Commit dbfbd2c

Browse files
committed
JS: Remove 'response' from default threat-models
I didn't want to put the configuration file in `semmle/javascript/frameworks/**/*.model.yml`, so created `ext/` as in other languages
1 parent 05dce8a commit dbfbd2c

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
extensions:
2+
- addsTo:
3+
pack: codeql/threat-models
4+
extensible: threatModelConfiguration
5+
data:
6+
# Since responses are enabled by default in the shared threat-models configuration,
7+
# we need to disable it here to keep existing behavior for the javascript analysis.
8+
- ["response", false, -2147483647]

javascript/ql/lib/qlpack.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ dataExtensions:
1818
- semmle/javascript/frameworks/**/model.yml
1919
- semmle/javascript/frameworks/**/*.model.yml
2020
- semmle/javascript/security/domains/**/*.model.yml
21+
- ext/*.model.yml
2122
warnOnImplicitThis: true
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
| default |
22
| remote |
33
| request |
4-
| response |

0 commit comments

Comments
 (0)