C++: remove unneeded exists variables

rdmarsh2 · rdmarsh2 · commit df4d156a3648 · 2023-06-01T11:28:12.000-04:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql b/cpp/ql/src/experimental/Security/CWE/CWE-193/ConstantSizeArrayOffByOne.ql
@@ -146,12 +146,12 @@ module ArrayAddressToDerefConfig implements DataFlow::StateConfigSig {
   predicate isAdditionalFlowStep(
     DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2
   ) {
-    exists(PointerArithmeticInstruction pai, Variable v, int size, int delta |
+    exists(PointerArithmeticInstruction pai, Variable v |
       state1 = TArray(v) and
       state2 = TOverflowArithmetic(pai) and
       pai.getLeft() = node1.asInstruction() and
       node2.asInstruction() = pai and
-      pointerArithOverflow(pai, v, size, _, delta)
+      pointerArithOverflow(pai, v, _, _, _)
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -146,12 +146,12 @@ module ArrayAddressToDerefConfig implements DataFlow::StateConfigSig {`
`146`	`146`	`predicate isAdditionalFlowStep(`
`147`	`147`	`DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2`
`148`	`148`	`) {`
`149`		`- exists(PointerArithmeticInstruction pai, Variable v, int size, int delta \|`
	`149`	`+ exists(PointerArithmeticInstruction pai, Variable v \|`
`150`	`150`	`state1 = TArray(v) and`
`151`	`151`	`state2 = TOverflowArithmetic(pai) and`
`152`	`152`	`pai.getLeft() = node1.asInstruction() and`
`153`	`153`	`node2.asInstruction() = pai and`
`154`		`- pointerArithOverflow(pai, v, size, _, delta)`
	`154`	`+ pointerArithOverflow(pai, v, _, _, _)`
`155`	`155`	`)`
`156`	`156`	`}`
`157`	`157`	`}`