Rust: Calculate a total of AST inconsistencies.

Author: geoffw0

rust/ql/lib/codeql/rust/AstConsistency.qll

@@ -35,3 +35,21 @@ query predicate multipleParents(Element child, Element parent) {
   parent = getParent(child) and
   strictcount(getParent(child)) > 1
 }
+
+/**
+ * Gets counts of abstract syntax tree inconsistencies of each type.
+ */
+int getAstInconsistencyCounts(string type) {
+  // total results from all the AST consistency query predicates.
+  type = "Multiple toStrings" and
+  result = count(Element e | multipleToStrings(e, _) | e)
+  or
+  type = "Multiple locations" and
+  result = count(Element e | multipleLocations(e) | e)
+  or
+  type = "Multiple primary QL classes" and
+  result = count(Element e | multiplePrimaryQlClasses(e, _) | e)
+  or
+  type = "Multiple parents" and
+  result = count(Element e | multipleParents(e, _) | e)
+}

rust/ql/src/queries/summary/Stats.qll

@@ -3,6 +3,7 @@
  */
 
 import rust
+import codeql.rust.AstConsistency as AstConsistency
 private import codeql.rust.controlflow.internal.CfgConsistency as CfgConsistency
 
 /**
@@ -17,6 +18,11 @@ int getLinesOfUserCode() {
   result = sum(File f | exists(f.getRelativePath()) | f.getNumberOfLinesOfCode())
 }
 
+/**
+ * Gets a count of the total number of abstract syntax tree inconsistencies in the database.
+ */
+int getTotalAstInconsistencies() { result = sum(AstConsistency::getAstInconsistencyCounts(_)) }
+
 /**
  * Gets a count of the total number of control flow graph inconsistencies in the database.
  */

rust/ql/src/queries/summary/SummaryStats.ql

@@ -34,5 +34,7 @@ where
   or
   key = "Lines of user code extracted" and value = getLinesOfUserCode().toString()
   or
+  key = "Inconsistencies - AST" and value = getTotalAstInconsistencies().toString()
+  or
   key = "Inconsistencies - CFG" and value = getTotalCfgInconsistencies().toString()
 select key, value

rust/ql/test/query-tests/diagnostics/SummaryStats.expected

@@ -5,6 +5,7 @@
 | Files extracted - total | 7 |
 | Files extracted - with errors | 2 |
 | Files extracted - without errors | 5 |
+| Inconsistencies - AST | 0 |
 | Inconsistencies - CFG | 0 |
 | Lines of code extracted | 59 |
 | Lines of user code extracted | 59 |