Skip to content

Commit e0e5bb1

Browse files
committed
Refactor RabbitMQ test
1 parent 2579852 commit e0e5bb1

File tree

1 file changed

+7
-11
lines changed
  • java/ql/test/library-tests/frameworks/rabbitmq

1 file changed

+7
-11
lines changed

java/ql/test/library-tests/frameworks/rabbitmq/FlowTest.ql

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,18 @@ import semmle.code.java.dataflow.TaintTracking
33
import semmle.code.java.dataflow.FlowSources
44
import TestUtilities.InlineFlowTest
55

6-
class EnableLegacy extends EnableLegacyConfiguration {
7-
EnableLegacy() { exists(this) }
8-
}
9-
10-
class Conf extends TaintTracking::Configuration {
11-
Conf() { this = "qltest:frameworks:rabbitmq" }
6+
module Config implements DataFlow::ConfigSig {
7+
predicate isSource(DataFlow::Node node) { node instanceof RemoteFlowSource }
128

13-
override predicate isSource(DataFlow::Node node) { node instanceof RemoteFlowSource }
14-
15-
override predicate isSink(DataFlow::Node node) {
9+
predicate isSink(DataFlow::Node node) {
1610
exists(MethodAccess ma | ma.getMethod().hasName("sink") | node.asExpr() = ma.getAnArgument())
1711
}
1812
}
1913

14+
module Flow = TaintTracking::Global<Config>;
15+
2016
class HasFlowTest extends InlineFlowTest {
21-
override DataFlow::Configuration getValueFlowConfig() { none() }
17+
override predicate hasValueFlow(DataFlow::Node src, DataFlow::Node sink) { none() }
2218

23-
override DataFlow::Configuration getTaintFlowConfig() { result = any(Conf c) }
19+
override predicate hasTaintFlow(DataFlow::Node src, DataFlow::Node sink) { Flow::flow(src, sink) }
2420
}

0 commit comments

Comments
 (0)