Skip to content

Commit e1aaa13

Browse files
committed
Rust: Add variants with pattern matching for unreachable_let_1 and 2.
1 parent 3d0c86e commit e1aaa13

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

rust/ql/test/query-tests/unusedentities/UnreachableCode.expected

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
| unreachable.rs:169:4:169:18 | ExprStmt | This code is never reached. |
1414
| unreachable.rs:177:4:177:18 | ExprStmt | This code is never reached. |
1515
| unreachable.rs:180:2:180:16 | ExprStmt | This code is never reached. |
16+
| unreachable.rs:197:2:197:16 | ExprStmt | This code is never reached. |
1617
| unreachable.rs:203:3:203:17 | ExprStmt | This code is never reached. |
1718
| unreachable.rs:206:2:206:16 | ExprStmt | This code is never reached. |
1819
| unreachable.rs:218:3:218:17 | ExprStmt | This code is never reached. |

rust/ql/test/query-tests/unusedentities/unreachable.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -187,14 +187,14 @@ fn unreachable_paren() {
187187
}
188188

189189
fn unreachable_let_1() {
190+
if let Some(a) = maybe_get_a_number() {
191+
do_something();
192+
return;
193+
} else {
194+
do_something();
195+
}
190196

191-
192-
193-
194-
195-
196-
197-
197+
do_something(); // SPURIOUS: unreachable code
198198

199199
if let a = get_a_number() { // (always succeeds)
200200
do_something();
@@ -207,12 +207,12 @@ fn unreachable_let_1() {
207207
}
208208

209209
fn unreachable_let_2() {
210+
let Some(a) = maybe_get_a_number() else {
211+
do_something();
212+
return;
213+
};
210214

211-
212-
213-
214-
215-
215+
do_something();
216216

217217
let a = maybe_get_a_number() else { // (always succeeds)
218218
do_something(); // BAD: unreachable code

0 commit comments

Comments
 (0)