Skip to content

Commit e259b25

Browse files
committed
Add "tokenizer" to sensitive variable name FPs
1 parent 0704946 commit e259b25

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

java/ql/lib/semmle/code/java/security/SensitiveActions.qll

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,12 @@ string getCommonSensitiveInfoRegex() {
4141
* indicate the value being held does not contains sensitive information,
4242
* but is a false positive for `getCommonSensitiveInfoRegex`.
4343
*
44+
* - "tokenizer" is often used for java.util.StringTokenizer.
4445
* - "tokenImage" appears in parser code generated by JavaCC.
4546
*/
46-
string getCommonSensitiveInfoFPRegex() { result = "(?i).*(null).*" or result = "tokenImage" }
47+
string getCommonSensitiveInfoFPRegex() {
48+
result = "(?i).*(null|tokenizer).*" or result = "tokenImage"
49+
}
4750

4851
/** An expression that might contain sensitive data. */
4952
abstract class SensitiveExpr extends Expr { }

java/ql/test/query-tests/security/CWE-532/Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ void test(String password, String authToken, String username, String nullToken,
88
logger.error("Auth failed for: " + authToken); // $ hasTaintFlow
99
logger.error("Auth failed for: " + username); // Safe
1010
logger.error("Auth failed for: " + nullToken); // Safe
11-
logger.error("Auth failed for: " + stringTokenizer); // $ hasTaintFlow
11+
logger.error("Auth failed for: " + stringTokenizer); // Safe
1212
}
1313
}

0 commit comments

Comments
 (0)