Skip to content

Commit e2eb6db

Browse files
committed
Ruby: Fix query compilation.
1 parent 6ffb9b1 commit e2eb6db

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

ruby/ql/lib/utils/test/InlineFlowTest.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* See `shared/util/codeql/dataflow/test/InlineFlowTest.qll`
44
*/
55

6-
import ruby
6+
private import ruby
77
private import codeql.Locations
88
private import codeql.dataflow.test.InlineFlowTest
99
private import codeql.ruby.dataflow.internal.DataFlowImplSpecific

ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import codeql.ruby.ast.internal.Constant
1616
import codeql.ruby.Concepts
1717
import codeql.ruby.frameworks.ActiveRecord
1818
private import codeql.ruby.TaintTracking
19-
private import codeql.ruby.CFG
2019
private import codeql.ruby.controlflow.internal.Guards as Guards
2120

2221
/** Gets the name of a built-in method that involves a loop operation. */
@@ -42,7 +41,7 @@ class LoopingCall extends DataFlow::CallNode {
4241

4342
/** Holds if `ar` influences a guard that may control the execution of a loop. */
4443
predicate usedInLoopControlGuard(ActiveRecordInstance ar) {
45-
exists(DataFlow::Node insideGuard, CfgNodes::ExprCfgNode guard |
44+
exists(DataFlow::Node insideGuard, Cfg::CfgNodes::ExprCfgNode guard |
4645
// For a guard like `cond && ar`, the whole guard will not be tainted
4746
// so we need to look at the taint of the individual parts.
4847
insideGuard.asExpr().getExpr() = guard.getExpr().getAChild*()
@@ -53,12 +52,12 @@ predicate usedInLoopControlGuard(ActiveRecordInstance ar) {
5352
}
5453

5554
/** Holds if `guard` controls `break` and `break` would break out of a loop. */
56-
predicate guardForLoopControl(CfgNodes::ExprCfgNode guard, CfgNodes::AstCfgNode break) {
55+
predicate guardForLoopControl(Cfg::CfgNodes::ExprCfgNode guard, Cfg::CfgNodes::AstCfgNode break) {
5756
Guards::guardControlsBlock(guard, break.getBasicBlock(), _) and
5857
(
59-
break.(CfgNodes::ExprNodes::MethodCallCfgNode).getMethodName() = "raise"
58+
break.(Cfg::CfgNodes::ExprNodes::MethodCallCfgNode).getMethodName() = "raise"
6059
or
61-
break instanceof CfgNodes::ReturningCfgNode
60+
break instanceof Cfg::CfgNodes::ReturningCfgNode
6261
)
6362
}
6463

ruby/ql/test/library-tests/controlflow/graph/BasicBlocks.ql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import ruby
21
import codeql.ruby.controlflow.ControlFlowGraph
32
import codeql.ruby.controlflow.BasicBlocks
43

ruby/ql/test/library-tests/dataflow/barrier-guards/barrier-flow.ql

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
* @kind path-problem
33
*/
44

5-
import codeql.ruby.AST
6-
import codeql.ruby.CFG
5+
import ruby
76
import utils.test.InlineFlowTest
87
import codeql.ruby.dataflow.BarrierGuards
98
import PathGraph

0 commit comments

Comments
 (0)