Skip to content

Commit e414b8c

Browse files
committed
Remove @input() decorated members as remote sources, in favour of a later Threat Model
1 parent 8dac00a commit e414b8c

File tree

1 file changed

+0
-36
lines changed

1 file changed

+0
-36
lines changed

javascript/ql/lib/semmle/javascript/security/dataflow/RemoteFlowSources.qll

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -184,39 +184,3 @@ private class ExternalRemoteFlowSource extends RemoteFlowSource {
184184

185185
override string getSourceType() { result = ap.getSourceType() }
186186
}
187-
188-
/**
189-
* An Angular @Input() decorator on a member declaration.
190-
*/
191-
class InputMember extends MemberDeclaration {
192-
InputMember() {
193-
exists(Decorator decorator, Expr expr |
194-
decorator.getElement() = this and
195-
decorator.getExpression() = expr and
196-
expr.(CallExpr).getCallee().(VarRef).getName() = "Input"
197-
)
198-
}
199-
}
200-
201-
/**
202-
* A use of an Angular @Input() member, modeled as `InputMember`.
203-
*/
204-
class InputMemberUse extends DataFlow::Node {
205-
InputMemberUse() {
206-
exists(InputMember member, string memberName, ThisExpr ta, FieldAccess fa |
207-
memberName = member.getName() and
208-
fa.getBase() = ta and
209-
fa.getPropertyName() = memberName and
210-
this.asExpr() = fa
211-
)
212-
}
213-
}
214-
215-
/**
216-
* A remote flow source that is a member of an Angular component class.
217-
*/
218-
private class AngularInputUse extends RemoteFlowSource, InputMemberUse {
219-
AngularInputUse() { this = this }
220-
221-
override string getSourceType() { result = "Angular @Input()" }
222-
}

0 commit comments

Comments
 (0)