Go: UnhandledCloseWritableHandle

d10c · d10c · commit e464e96d3140 · 2025-07-07T11:39:58.000+02:00
diff --git a/go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql b/go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql
@@ -129,8 +129,12 @@ module UnhandledFileCloseConfig implements DataFlow::ConfigSig {
 
   predicate isSink(DataFlow::Node sink) { isCloseSink(sink, _) }
 
-  predicate observeDiffInformedIncrementalMode() {
-    any() // TODO: Make sure that the location overrides match the query's select clause: Column 5 does not select a source or sink originating from the flow call on line 147 (/Users/d10c/src/semmle-code/ql/go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql@153:3:153:10)
+  predicate observeDiffInformedIncrementalMode() { any() }
+
+  Location getASelectedSourceLocation(DataFlow::Node source) {
+    exists(DataFlow::CallNode openCall | result = openCall.getLocation() |
+      isWritableFileHandle(source, openCall)
+    )
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,12 @@ module UnhandledFileCloseConfig implements DataFlow::ConfigSig {`
`129`	`129`
`130`	`130`	`predicate isSink(DataFlow::Node sink) { isCloseSink(sink, _) }`
`131`	`131`
`132`		`- predicate observeDiffInformedIncrementalMode() {`
`133`		`- any() // TODO: Make sure that the location overrides match the query's select clause: Column 5 does not select a source or sink originating from the flow call on line 147 (/Users/d10c/src/semmle-code/ql/go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql@153:3:153:10)`
	`132`	`+ predicate observeDiffInformedIncrementalMode() { any() }`
	`133`	`+`
	`134`	`+ Location getASelectedSourceLocation(DataFlow::Node source) {`
	`135`	`+ exists(DataFlow::CallNode openCall \| result = openCall.getLocation() \|`
	`136`	`+ isWritableFileHandle(source, openCall)`
	`137`	`+ )`
`134`	`138`	`}`
`135`	`139`	`}`
`136`	`140`