Skip to content

Commit e4cd29e

Browse files
committed
Fix missing go-jose package path
1 parent d75da82 commit e4cd29e

File tree

5 files changed

+24
-8
lines changed

5 files changed

+24
-8
lines changed

go/ql/lib/ext/github.com.go-jose.go-jose.jwt.model.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ extensions:
33
pack: codeql/go-all
44
extensible: packageGrouping
55
data:
6-
- ["go-jose/jwt", "github.com/go-jose/go-jose/jwt"]
76
- ["go-jose/jwt", "gopkg.in/square/go-jose/jwt"]
7+
- ["go-jose/jwt", "gopkg.in/go-jose/go-jose/jwt"]
88
- ["go-jose/jwt", "github.com/square/go-jose/jwt"]
9+
- ["go-jose/jwt", "github.com/go-jose/go-jose/jwt"]
910
- addsTo:
1011
pack: codeql/go-all
1112
extensible: sinkModel

go/ql/lib/ext/github.com.go-jose.go-jose.model.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@ extensions:
33
pack: codeql/go-all
44
extensible: packageGrouping
55
data:
6-
- ["go-jose", "github.com/go-jose/go-jose"]
76
- ["go-jose", "gopkg.in/square/go-jose"]
7+
- ["go-jose", "gopkg.in/go-jose/go-jose"]
88
- ["go-jose", "github.com/square/go-jose"]
9+
- ["go-jose", "github.com/go-jose/go-jose"]
910
- addsTo:
1011
pack: codeql/go-all
1112
extensible: sinkModel

go/ql/lib/semmle/go/frameworks/GoJose.qll

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
2-
* Provides classes for working with the `github.com/square/go-jose`, `github.com/go-jose/go-jose`,
3-
* and `gopkg.in/square-go-jose.v2` packages.
2+
* Provides classes for working with the `gopkg.in/square/go-jose` and `github.com/go-jose/go-jose`
3+
* packages.
44
*/
55

66
import go
@@ -22,9 +22,16 @@ private module GoJose {
2222
override int getTokenArgNum() { result = -1 }
2323
}
2424

25-
/** Gets the package names `gopkg.in/square/go-jose/jwt` and `github.com/go-jose/go-jose/jwt`. */
25+
/**
26+
* Gets the package names `gopkg.in/square/go-jose/jwt`, `gopkg.in/go-jose/go-jose/jwt`,
27+
* `github.com/square/go-jose/jwt`, and `github.com/go-jose/go-jose/jwt`.
28+
*/
2629
private string goJoseJwtPackage() {
27-
result = package(["gopkg.in/square/go-jose", "github.com/go-jose/go-jose"], "jwt")
30+
result =
31+
package([
32+
"gopkg.in/square/go-jose", "gopkg.in/go-jose/go-jose", "github.com/square/go-jose",
33+
"github.com/go-jose/go-jose"
34+
], "jwt")
2835
}
2936
}
3037
}

go/ql/lib/semmle/go/security/ExternalAPIs.qll

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,10 @@ private class DefaultSafeExternalApiFunction extends SafeExternalApiFunction {
3636
DefaultSafeExternalApiFunction() {
3737
this instanceof BuiltinFunction or
3838
isDefaultSafePackage(this.getPackage()) or
39-
this.hasQualifiedName(package("gopkg.in/square/go-jose", "jwt"), "ParseSigned") or
39+
this.hasQualifiedName(package([
40+
"gopkg.in/square/go-jose", "gopkg.in/go-jose/go-jose", "github.com/square/go-jose",
41+
"github.com/go-jose/go-jose"
42+
], "jwt"), "ParseSigned") or
4043
this.(Method).hasQualifiedName(Gorm::packagePath(), "DB", "Update") or
4144
this.hasQualifiedName("crypto/hmac", "Equal") or
4245
this.hasQualifiedName("crypto/subtle", "ConstantTimeCompare") or

go/ql/src/experimental/frameworks/JWT.qll

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,11 @@ class GolangJwtParseFromRequestWithClaims extends JwtParseWithKeyFunction {
172172
* Gets `gopkg.in/square/go-jose` and `github.com/go-jose/go-jose` jwt package
173173
*/
174174
string goJoseJwtPackage() {
175-
result = package(["gopkg.in/square/go-jose", "github.com/go-jose/go-jose"], "jwt")
175+
result =
176+
package([
177+
"gopkg.in/square/go-jose", "gopkg.in/go-jose/go-jose", "github.com/square/go-jose",
178+
"github.com/go-jose/go-jose"
179+
], "jwt")
176180
}
177181

178182
/**

0 commit comments

Comments
 (0)