JS: Add quotes around package name to correct parsing

asgerf · asgerf · commit e4f23b31c69f · 2024-04-23T20:04:23.000+02:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/data/ModelsAsData.qll b/javascript/ql/lib/semmle/javascript/frameworks/data/ModelsAsData.qll
@@ -108,7 +108,11 @@ module ModelExport<ModelExportSig S> {
     }
 
     predicate exposedName(API::Node node, string type, string path) {
-      node = API::moduleExport(type) and path = ""
+      exists(string moduleName |
+        node = API::moduleExport(moduleName) and
+        path = "" and
+        type = "'" + moduleName + "'"
+      )
     }
 
     predicate suggestedName(API::Node node, string type) {

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,11 @@ module ModelExport<ModelExportSig S> {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`predicate exposedName(API::Node node, string type, string path) {`
`111`		`- node = API::moduleExport(type) and path = ""`
	`111`	`+ exists(string moduleName \|`
	`112`	`+ node = API::moduleExport(moduleName) and`
	`113`	`+ path = "" and`
	`114`	`+ type = "'" + moduleName + "'"`
	`115`	`+ )`
`112`	`116`	`}`
`113`	`117`
`114`	`118`	`predicate suggestedName(API::Node node, string type) {`