Rename parameter

joefarebrother · joefarebrother · commit e61612298258 · 2021-10-20T17:09:59.000+01:00
diff --git a/java/ql/lib/semmle/code/java/security/AndroidSensitiveBroadcastQuery.qll b/java/ql/lib/semmle/code/java/security/AndroidSensitiveBroadcastQuery.qll
@@ -53,9 +53,9 @@ private predicate maybeEmptyArrayArg(Expr ex) {
 /**
  * Holds if a `sendBroadcast` call doesn't specify receiver permission.
  */
-private predicate isSensitiveBroadcastSink(DataFlow::Node sink) {
+private predicate isSensitiveBroadcastSink(DataFlow::Node sendBroadcastCallArg) {
   exists(SendBroadcastMethodAccess ma, string name | ma.getMethod().hasName(name) |
-    sink.asExpr() = ma.getAnArgument() and
+    sendBroadcastCallArg.asExpr() = ma.getAnArgument() and
     (
       name = "sendBroadcast" and
       (

Original file line number	Diff line number	Diff line change
`@@ -53,9 +53,9 @@ private predicate maybeEmptyArrayArg(Expr ex) {`
`53`	`53`	`/**`
`54`	`54`	* Holds if a `sendBroadcast` call doesn't specify receiver permission.
`55`	`55`	`*/`
`56`		`-private predicate isSensitiveBroadcastSink(DataFlow::Node sink) {`
	`56`	`+private predicate isSensitiveBroadcastSink(DataFlow::Node sendBroadcastCallArg) {`
`57`	`57`	`exists(SendBroadcastMethodAccess ma, string name \| ma.getMethod().hasName(name) \|`
`58`		`- sink.asExpr() = ma.getAnArgument() and`
	`58`	`+ sendBroadcastCallArg.asExpr() = ma.getAnArgument() and`
`59`	`59`	`(`
`60`	`60`	`name = "sendBroadcast" and`
`61`	`61`	`(`