C++: add bindingset to private Printf predicate

redsun82 · web-flow · commit e6763c858dac · 2022-01-13T11:59:48.000Z
That predicate turned out to create a lot of tuples, of which only a
minimal part was then used in the query.
diff --git a/cpp/ql/lib/semmle/code/cpp/commons/Printf.qll b/cpp/ql/lib/semmle/code/cpp/commons/Printf.qll
@@ -382,6 +382,7 @@ private int lengthInBase10(float f) {
   result = f.log10().floor() + 1
 }
 
+bindingset[expr]
 private BufferWriteEstimationReason getEstimationReasonForIntegralExpression(Expr expr) {
   // we consider the range analysis non trivial if it
   // * constrained non-trivially both sides of a signed value, or

Original file line number	Diff line number	Diff line change
`@@ -382,6 +382,7 @@ private int lengthInBase10(float f) {`
`382`	`382`	`result = f.log10().floor() + 1`
`383`	`383`	`}`
`384`	`384`
	`385`	`+bindingset[expr]`
`385`	`386`	`private BufferWriteEstimationReason getEstimationReasonForIntegralExpression(Expr expr) {`
`386`	`387`	`// we consider the range analysis non trivial if it`
`387`	`388`	`// * constrained non-trivially both sides of a signed value, or`