Skip to content

Commit e6984aa

Browse files
committed
Ruby: Remove two redundant allowImplicitRead predicates
1 parent aa24c29 commit e6984aa

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

ruby/ql/lib/codeql/ruby/security/UnsafeCodeConstructionQuery.qll

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,6 @@ private module UnsafeCodeConstructionConfig implements DataFlow::ConfigSig {
4646

4747
// override to require the path doesn't have unmatched return steps
4848
DataFlow::FlowFeature getAFeature() { result instanceof DataFlow::FeatureHasSourceCallContext }
49-
50-
predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet set) {
51-
// allow implicit reads of array elements
52-
isSink(node) and
53-
set.isElementOfTypeOrUnknown("int")
54-
}
5549
}
5650

5751
/**

ruby/ql/lib/codeql/ruby/security/UnsafeShellCommandConstructionQuery.qll

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,6 @@ private module UnsafeShellCommandConstructionConfig implements DataFlow::ConfigS
4949

5050
// override to require the path doesn't have unmatched return steps
5151
DataFlow::FlowFeature getAFeature() { result instanceof DataFlow::FeatureHasSourceCallContext }
52-
53-
predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet set) {
54-
// allow implicit reads of array elements
55-
isSink(node) and
56-
set.isElementOfTypeOrUnknown("int")
57-
}
5852
}
5953

6054
/**

0 commit comments

Comments
 (0)