Merge pull request #6885 from aschackmull/java/perffix-transitve-step

aschackmull · web-flow · commit eb0a88d39cc9 · 2021-10-14T16:51:51.000+02:00
Java: Fix performance problem due to transitive step.
diff --git a/java/ql/lib/semmle/code/java/frameworks/spring/SpringHttp.qll b/java/ql/lib/semmle/code/java/frameworks/spring/SpringHttp.qll
@@ -280,7 +280,7 @@ private DataFlow::Node getABodyBuilderWithExplicitContentType(Expr contentType)
           .hasQualifiedName("org.springframework.http", "ResponseEntity$BodyBuilder")
     )
   or
-  DataFlow::localFlow(getABodyBuilderWithExplicitContentType(contentType), result)
+  DataFlow::localFlowStep(getABodyBuilderWithExplicitContentType(contentType), result)
 }
 
 private DataFlow::Node getASanitizedBodyBuilder() {

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ private DataFlow::Node getABodyBuilderWithExplicitContentType(Expr contentType)`
`280`	`280`	`.hasQualifiedName("org.springframework.http", "ResponseEntity$BodyBuilder")`
`281`	`281`	`)`
`282`	`282`	`or`
`283`		`- DataFlow::localFlow(getABodyBuilderWithExplicitContentType(contentType), result)`
	`283`	`+ DataFlow::localFlowStep(getABodyBuilderWithExplicitContentType(contentType), result)`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`private DataFlow::Node getASanitizedBodyBuilder() {`