Java: replace exists with instanceof

Jami Cogswell · Jami Cogswell · commit f0124dae1ac3 · 2022-12-12T16:40:19.000-05:00
diff --git a/java/ql/src/Metrics/Summaries/GeneratedVsManualCoverage.ql b/java/ql/src/Metrics/Summaries/GeneratedVsManualCoverage.ql
@@ -20,7 +20,7 @@ private int getNumMadModeledApis(string package, string provenance) {
   result =
     count(SummarizedCallable sc |
       package = sc.asCallable().getCompilationUnit().getPackage().getName() and
-      exists(DataFlowTargetApi dataFlowTargApi | sc.asCallable() = dataFlowTargApi) and
+      sc.asCallable() instanceof DataFlowTargetApi and
       (
         sc.isAutoGenerated() and // "auto-only"
         provenance = "generated"

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ private int getNumMadModeledApis(string package, string provenance) {`
`20`	`20`	`result =`
`21`	`21`	`count(SummarizedCallable sc \|`
`22`	`22`	`package = sc.asCallable().getCompilationUnit().getPackage().getName() and`
`23`		`- exists(DataFlowTargetApi dataFlowTargApi \| sc.asCallable() = dataFlowTargApi) and`
	`23`	`+ sc.asCallable() instanceof DataFlowTargetApi and`
`24`	`24`	`(`
`25`	`25`	`sc.isAutoGenerated() and // "auto-only"`
`26`	`26`	`provenance = "generated"`