C++: Fix mistake in previous commit.

geoffw0 · geoffw0 · commit f17c06a37f93 · 2021-10-20T15:40:14.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/commons/NullTermination.qll b/cpp/ql/lib/semmle/code/cpp/commons/NullTermination.qll
@@ -45,7 +45,7 @@ predicate mayAddNullTerminator(Expr e, VariableAccess va) {
   // Assignment to another stack variable
   exists(Expr e0 |
     mayAddNullTerminatorHelper(pragma[only_bind_into](e), va, pragma[only_bind_into](e0)) and
-    nodeBefore(e0, e)
+    nodeBefore(e, e0)
   )
   or
   // Assignment to non-stack variable

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ predicate mayAddNullTerminator(Expr e, VariableAccess va) {`
`45`	`45`	`// Assignment to another stack variable`
`46`	`46`	`exists(Expr e0 \|`
`47`	`47`	`mayAddNullTerminatorHelper(pragma[only_bind_into](e), va, pragma[only_bind_into](e0)) and`
`48`		`- nodeBefore(e0, e)`
	`48`	`+ nodeBefore(e, e0)`
`49`	`49`	`)`
`50`	`50`	`or`
`51`	`51`	`// Assignment to non-stack variable`