Skip to content

Commit f1df542

Browse files
committed
Add stubs & tests
Fix mistakes detected by the tests
1 parent 7d88f80 commit f1df542

File tree

25 files changed

+4872
-84
lines changed

25 files changed

+4872
-84
lines changed

java/ql/lib/semmle/code/java/frameworks/Logging.qll

Lines changed: 177 additions & 84 deletions
Large diffs are not rendered by default.

java/ql/test/query-tests/security/CWE-117/LogInjectionTest.expected

Whitespace-only changes.

java/ql/test/query-tests/security/CWE-117/LogInjectionTest.java

Lines changed: 1956 additions & 0 deletions
Large diffs are not rendered by default.

java/ql/test/query-tests/security/CWE-117/LogInjectionTest.ql

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@ import java
22
import semmle.code.java.security.LogInjectionQuery
33
import TestUtilities.InlineFlowTest
44

5+
private class TestSource extends RemoteFlowSource {
6+
TestSource() { this.asExpr().(MethodAccess).getMethod().hasName("source") }
7+
8+
override string getSourceType() { result = "test source" }
9+
}
10+
511
private class LogInjectionTest extends InlineFlowTest {
612
override DataFlow::Configuration getValueFlowConfig() { none() }
713

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
//semmle-extractor-options: --javac-args -cp ${testdir}/../../../stubs/apache-log4j-1.2.17:${testdir}/../../../stubs/apache-log4j-2.14.1:${testdir}/../../../stubs/apache-commons-logging-1.2:${testdir}/../../../stubs/jboss-logging-3.4.2:${testdir}/../../../stubs/slf4j-2.0.0:${testdir}/../../../stubs/scijava-common-2.87.1:${testdir}/../../../stubs/flogger-0.7.1:${testdir}/../../../stubs/google-android-9.0.0

java/ql/test/stubs/apache-commons-logging-1.2/org/apache/commons/logging/Log.java

Lines changed: 52 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Appender.java

Lines changed: 47 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Category.java

Lines changed: 181 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Layout.java

Lines changed: 25 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

java/ql/test/stubs/apache-log4j-1.2.17/org/apache/log4j/Level.java

Lines changed: 26 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)