Removing redundant/bad string type check.

bdrodes · bdrodes · commit f26330e6bd53 · 2023-12-19T09:41:29.000-05:00
diff --git a/cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll b/cpp/ql/lib/semmle/code/cpp/commons/StringConcatenation.qll
@@ -50,8 +50,6 @@ class StringConcatenation extends Call {
     (
       result.getUnderlyingType().stripType().getName() = "char"
       or
-      result.getUnderlyingType().getName() = "string"
-      or
       result
           .getType()
           .getUnspecifiedType()

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,6 @@ class StringConcatenation extends Call {`
`50`	`50`	`(`
`51`	`51`	`result.getUnderlyingType().stripType().getName() = "char"`
`52`	`52`	`or`
`53`		`- result.getUnderlyingType().getName() = "string"`
`54`		`- or`
`55`	`53`	`result`
`56`	`54`	`.getType()`
`57`	`55`	`.getUnspecifiedType()`