CPP: Fix metadata and add a change-note.

alexet · alexet · commit f3f53570a486 · 2023-12-04T12:19:31.000Z
diff --git a/cpp/ql/src/Critical/IncorrectCheckScanf.ql b/cpp/ql/src/Critical/IncorrectCheckScanf.ql
@@ -5,11 +5,10 @@
  * @kind problem
  * @problem.severity warning
  * @security-severity 7.5
- * @precision medium
- * @id cpp/discarded-scanf
+ * @precision high
+ * @id cpp/incorrectly-checked-scanf
  * @tags security
  *       correctness
- *       external/cwe/cwe-252
  *       external/cwe/cwe-253
  */
 
diff --git a/cpp/ql/src/change-notes/2023-12-4-incorrectly-checked-scanf.md b/cpp/ql/src/change-notes/2023-12-4-incorrectly-checked-scanf.md
@@ -0,0 +1,4 @@
+---
+category: new-query
+---
+* The `cpp/incorrectly-checked-scanf` query has been added. This finds results where the return value of scanf is not checked correctly. Some of these were previously found by `cpp/missing-check-scanf` and will no longer be reported there.

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: new-query
 +---
 +* The `cpp/incorrectly-checked-scanf` query has been added. This finds results where the return value of scanf is not checked correctly. Some of these were previously found by `cpp/missing-check-scanf` and will no longer be reported there.