Skip to content

Commit f404d7a

Browse files
committed
Changes to address pr comments.
1 parent b9ac038 commit f404d7a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cpp/ql/lib/semmle/code/cpp/models/Models.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ private import implementations.Iterator
99
private import implementations.MemberFunction
1010
private import implementations.Memcpy
1111
private import implementations.Memset
12-
private import implementations.ODBC
1312
private import implementations.Printf
1413
private import implementations.Pure
1514
private import implementations.Strcat
@@ -36,6 +35,7 @@ private import implementations.Accept
3635
private import implementations.Poll
3736
private import implementations.Select
3837
private import implementations.MySql
38+
private import implementations.ODBC
3939
private import implementations.SqLite3
4040
private import implementations.PostgreSql
4141
private import implementations.System

cpp/ql/lib/semmle/code/cpp/models/implementations/ODBC.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ private import semmle.code.cpp.models.interfaces.FunctionInputsAndOutputs
1818
*/
1919
private class ODBCExecutionFunction extends SqlExecutionFunction {
2020
ODBCExecutionFunction() {
21-
exists(string s | s in ["SQLExecDirect", "SQLPrepare"] and this.hasName(s))
21+
this.hasGlobalName(["SQLExecDirect", "SQLPrepare"])
2222
}
2323

2424
override predicate hasSqlArgument(FunctionInput input) { input.isParameterDeref(1) }

0 commit comments

Comments
 (0)