Skip to content

Commit f464f1b

Browse files
Accept test output + fix qldoc typo
1 parent b4ed773 commit f464f1b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

ruby/ql/lib/codeql/ruby/frameworks/ActionController.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ private module ParamsSummaries {
522522
exists(TypeTracker t2 | result = paramsFieldType(t2).track(t2, t))
523523
}
524524

525-
/** Gets a node with a type that can be a field of `ActionController::Parameters */
525+
/** Gets a node with a type that can be a field of `ActionController::Parameters` */
526526
private DataFlow::LocalSourceNode paramsFieldType() {
527527
paramsFieldType(TypeTracker::end()).flowsTo(result)
528528
}

ruby/ql/test/library-tests/frameworks/action_controller/ActionController.expected

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ actionControllerControllerClasses
1414
| input_access.rb:1:1:58:3 | UsersController |
1515
| params_flow.rb:1:1:162:3 | MyController |
1616
| params_flow.rb:170:1:178:3 | Subclass |
17-
| params_flow.rb:180:1:205:5 | UploadedFileTests |
17+
| params_flow.rb:180:1:207:3 | UploadedFileTests |
1818
actionControllerActionMethods
1919
| app/controllers/comments_controller.rb:17:3:51:5 | index |
2020
| app/controllers/comments_controller.rb:53:3:54:5 | create |
@@ -91,8 +91,8 @@ actionControllerActionMethods
9191
| params_flow.rb:185:3:187:5 | m37 |
9292
| params_flow.rb:189:3:191:5 | m38 |
9393
| params_flow.rb:193:3:195:5 | m39 |
94-
| params_flow.rb:197:3:201:5 | m40 |
95-
| params_flow.rb:203:3:205:5 | m41 |
94+
| params_flow.rb:197:3:200:5 | m40 |
95+
| params_flow.rb:202:3:206:5 | m41 |
9696
paramsCalls
9797
| app/controllers/comments_controller.rb:80:36:80:41 | call to params |
9898
| app/controllers/foo/bars_controller.rb:13:21:13:26 | call to params |
@@ -157,8 +157,8 @@ paramsCalls
157157
| params_flow.rb:186:10:186:15 | call to params |
158158
| params_flow.rb:190:10:190:15 | call to params |
159159
| params_flow.rb:194:10:194:15 | call to params |
160-
| params_flow.rb:199:5:199:10 | call to params |
161-
| params_flow.rb:204:10:204:15 | call to params |
160+
| params_flow.rb:198:5:198:10 | call to params |
161+
| params_flow.rb:204:5:204:10 | call to params |
162162
paramsSources
163163
| app/controllers/comments_controller.rb:80:36:80:41 | call to params |
164164
| app/controllers/foo/bars_controller.rb:13:21:13:26 | call to params |
@@ -223,8 +223,8 @@ paramsSources
223223
| params_flow.rb:186:10:186:15 | call to params |
224224
| params_flow.rb:190:10:190:15 | call to params |
225225
| params_flow.rb:194:10:194:15 | call to params |
226-
| params_flow.rb:199:5:199:10 | call to params |
227-
| params_flow.rb:204:10:204:15 | call to params |
226+
| params_flow.rb:198:5:198:10 | call to params |
227+
| params_flow.rb:204:5:204:10 | call to params |
228228
httpInputAccesses
229229
| app/controllers/application_controller.rb:11:53:11:64 | call to path | ActionDispatch::Request#path |
230230
| app/controllers/comments_controller.rb:18:5:18:18 | call to params | ActionDispatch::Request#params |
@@ -347,8 +347,8 @@ httpInputAccesses
347347
| params_flow.rb:186:10:186:15 | call to params | ActionController::Metal#params |
348348
| params_flow.rb:190:10:190:15 | call to params | ActionController::Metal#params |
349349
| params_flow.rb:194:10:194:15 | call to params | ActionController::Metal#params |
350-
| params_flow.rb:199:5:199:10 | call to params | ActionController::Metal#params |
351-
| params_flow.rb:204:10:204:15 | call to params | ActionController::Metal#params |
350+
| params_flow.rb:198:5:198:10 | call to params | ActionController::Metal#params |
351+
| params_flow.rb:204:5:204:10 | call to params | ActionController::Metal#params |
352352
cookiesCalls
353353
| app/controllers/foo/bars_controller.rb:10:27:10:33 | call to cookies |
354354
cookiesSources

0 commit comments

Comments
 (0)