Java: remove previous uses of isUninteresting

Author: Jami Cogswell

java/ql/src/Telemetry/ExternalLibraryUsage.ql

@@ -14,8 +14,7 @@ private predicate getRelevantUsages(string jarname, int usages) {
     strictcount(Call c, ExternalApi a |
       c.getCallee().getSourceDeclaration() = a and
       not c.getFile() instanceof GeneratedFile and
-      a.jarContainer() = jarname and
-      not a.isUninteresting()
+      a.jarContainer() = jarname
     )
 }
 

java/ql/src/Telemetry/SupportedExternalApis.ql

@@ -11,11 +11,8 @@ import semmle.code.java.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl
 import ExternalApi
 
 private predicate relevant(ExternalApi api) {
-  not api.isUninteresting() and
-  (
-    api.isSupported() or
-    api = any(FlowSummaryImpl::Public::NegativeSummarizedCallable nsc).asCallable()
-  )
+  api.isSupported() or
+  api = any(FlowSummaryImpl::Public::NegativeSummarizedCallable nsc).asCallable()
 }
 
 from string apiName, int usages

java/ql/src/Telemetry/SupportedExternalSinks.ql

@@ -9,10 +9,7 @@
 import java
 import ExternalApi
 
-private predicate relevant(ExternalApi api) {
-  not api.isUninteresting() and
-  api.isSink()
-}
+private predicate relevant(ExternalApi api) { api.isSink() }
 
 from string apiName, int usages
 where Results<relevant/1>::restrict(apiName, usages)

java/ql/src/Telemetry/SupportedExternalSources.ql

@@ -9,10 +9,7 @@
 import java
 import ExternalApi
 
-private predicate relevant(ExternalApi api) {
-  not api.isUninteresting() and
-  api.isSource()
-}
+private predicate relevant(ExternalApi api) { api.isSource() }
 
 from string apiName, int usages
 where Results<relevant/1>::restrict(apiName, usages)

java/ql/src/Telemetry/SupportedExternalTaint.ql

@@ -9,10 +9,7 @@
 import java
 import ExternalApi
 
-private predicate relevant(ExternalApi api) {
-  not api.isUninteresting() and
-  api.hasSummary()
-}
+private predicate relevant(ExternalApi api) { api.hasSummary() }
 
 from string apiName, int usages
 where Results<relevant/1>::restrict(apiName, usages)

java/ql/src/Telemetry/UnsupportedExternalAPIs.ql

@@ -11,7 +11,6 @@ import semmle.code.java.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl
 import ExternalApi
 
 private predicate relevant(ExternalApi api) {
-  not api.isUninteresting() and
   not api.isSupported() and
   not api = any(FlowSummaryImpl::Public::NegativeSummarizedCallable nsc).asCallable()
 }