Use Expr::getValueText

nickrolfe · nickrolfe · commit f500e5b2d7c0 · 2021-10-08T16:41:06.000+01:00
diff --git a/ql/lib/codeql/ruby/security/UnsafeDeserializationCustomizations.qll b/ql/lib/codeql/ruby/security/UnsafeDeserializationCustomizations.qll
@@ -74,7 +74,7 @@ module UnsafeDeserialization {
   }
 
   private predicate isOjModePair(Pair p, string modeValue) {
-    p.getKey().(SymbolLiteral).getValueText() = "mode" and
+    p.getKey().getValueText() = "mode" and
     exists(DataFlow::LocalSourceNode symbolLiteral, DataFlow::Node value |
       symbolLiteral.asExpr().getExpr().(SymbolLiteral).getValueText() = modeValue and
       symbolLiteral.flowsTo(value) and

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ module UnsafeDeserialization {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`private predicate isOjModePair(Pair p, string modeValue) {`
`77`		`- p.getKey().(SymbolLiteral).getValueText() = "mode" and`
	`77`	`+ p.getKey().getValueText() = "mode" and`
`78`	`78`	`exists(DataFlow::LocalSourceNode symbolLiteral, DataFlow::Node value \|`
`79`	`79`	`symbolLiteral.asExpr().getExpr().(SymbolLiteral).getValueText() = modeValue and`
`80`	`80`	`symbolLiteral.flowsTo(value) and`