Skip to content

Commit f76cde3

Browse files
yofftausbn
andauthored
Apply suggestions from code review
Co-authored-by: Taus <[email protected]>
1 parent 1f8a51c commit f76cde3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -393,12 +393,12 @@ module StepRelationTransformations {
393393
* Consider a read from a global variable `x = foo`. At import time there should be a local flow step from `foo` to `x`,
394394
* while at runtime there should be a jump step from the module variable corresponding to `foo` to `x`.
395395
*
396-
* Similarly for, a write `foo = y`, at import time, there is a local flow step from `y` to `foo` while at runtime there
396+
* Similarly, for a write `foo = y`, at import time, there is a local flow step from `y` to `foo` while at runtime there
397397
* is a jump step from `y` to the module variable corresponding to `foo`.
398398
*
399399
* We need a way of distinguishing if we are looking at import time or runtime. We have the following helpful facts:
400400
* - All top-level executable statements are import time (and import time only)
401-
* - All -non-top-level code may be executed at runtime (but could also be executed at import time)
401+
* - All non-top-level code may be executed at runtime (but could also be executed at import time)
402402
*
403403
* We could write an analysis to determine which functions are called at import time, but until we have that, we will go
404404
* with the heuristic that global variables act according to import time rules at top-level program points and according
@@ -409,7 +409,7 @@ module StepRelationTransformations {
409409
* Holds if `node` is found at the top level of a module.
410410
*/
411411
pragma[inline]
412-
predicate isTopLevel(Node node) { node.getScope() instanceof Module }
412+
private predicate isTopLevel(Node node) { node.getScope() instanceof Module }
413413

414414
/** Holds if a step can be taken from `nodeFrom` to `nodeTo` at import time. */
415415
predicate importTimeStep(Node nodeFrom, Node nodeTo) {

0 commit comments

Comments
 (0)