C++: Don't generate dataflow nodes for instructions inside summarized callables.

MathiasVP · MathiasVP · commit fc39df28b0b2 · 2025-01-24T20:05:19.000Z
diff --git a/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll b/cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll
@@ -41,7 +41,9 @@ predicate ignoreInstruction(Instruction instr) {
     instr instanceof AliasedUseInstruction or
     instr instanceof InitializeNonLocalInstruction or
     instr instanceof ReturnIndirectionInstruction or
-    instr instanceof UninitializedGroupInstruction
+    instr instanceof UninitializedGroupInstruction or
+    // We exclude instruction belonging to functions that have a summary.
+    instr.getEnclosingFunction() = any(SummarizedCallable sc).getUnderlyingCallable()
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,9 @@ predicate ignoreInstruction(Instruction instr) {`
`41`	`41`	`instr instanceof AliasedUseInstruction or`
`42`	`42`	`instr instanceof InitializeNonLocalInstruction or`
`43`	`43`	`instr instanceof ReturnIndirectionInstruction or`
`44`		`- instr instanceof UninitializedGroupInstruction`
	`44`	`+ instr instanceof UninitializedGroupInstruction or`
	`45`	`+ // We exclude instruction belonging to functions that have a summary.`
	`46`	`+ instr.getEnclosingFunction() = any(SummarizedCallable sc).getUnderlyingCallable()`
`45`	`47`	`)`
`46`	`48`	`}`
`47`	`49`