Skip to content

Commit ff2f5a5

Browse files
atorralbasj
andauthored
Apply suggestions from code review
Co-authored-by: Bas van Schaik <[email protected]>
1 parent d2dc199 commit ff2f5a5

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

java/ql/src/experimental/Security/CWE/CWE-020/Log4jJndiInjection.qhelp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,14 @@ From Log4j 2.15.0, this behavior has been disabled by default. Note that this qu
2020
This issue was remediated in Log4j v2.15.0. The Apache Logging Services team provides the following mitigation advice:
2121
</p>
2222
<p>
23-
In previous releases (>=2.10) this behavior can be mitigated by setting system property "log4j2.formatMsgNoLookups" to “true”
24-
or by removing the JndiLookup class from the classpath (example: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class).
25-
Java 8u121 protects against RCE by defaulting "com.sun.jndi.rmi.object.trustURLCodebase" and "com.sun.jndi.cosnaming.object.trustURLCodebase" to "false".
23+
In previous releases (>=2.10) this behavior can be mitigated by setting system property <code>log4j2.formatMsgNoLookups</code> to <code>true</code>
24+
or by removing the <code>JndiLookup</code> class from the classpath (example: <code>zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class</code>).
2625
</p>
2726
<p>
2827
You can manually check for use of affected versions of Log4j by searching your project repository for Log4j use, which is often in a pom.xml file.
2928
</p>
3029
<p>
31-
Where possible, upgrade to Log4J version 2.15.0. If you are using Log4J v1 there is a migration guide available.
30+
Where possible, upgrade to Log4j version 2.15.0. If you are using Log4j v1 there is a migration guide available.
3231
</p>
3332
<p>
3433
Please note that Log4j v1 is End Of Life (EOL) and will not receive patches for this issue. Log4j v1 is also vulnerable to other RCE vectors and we

0 commit comments

Comments
 (0)