Java/more thread safe initialisers #20910
Open
+73
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances Java thread safety analysis to recognize when fields are initialized with thread-safe types inside constructors, not just in field initializer expressions. This reduces false positives when fields are assigned thread-safe collections (like ConcurrentHashMap or synchronized maps) in constructors.
Key Changes:
- Added
initialValuepredicate to check both field initializers and constructor assignments - Modified
ExposedFieldclass to use the new predicate for more comprehensive thread-safety checking - Added comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
java/ql/lib/semmle/code/java/ConflictingAccess.qll |
Implements the core logic by adding initialValue predicate and updating ExposedField to check constructor assignments |
java/ql/test/query-tests/ThreadSafe/examples/ThreadSafeInitializers.java |
Adds test cases demonstrating thread-safe initialization patterns in constructors |
java/ql/test/query-tests/ThreadSafe/ThreadSafe.expected |
Updates expected test results to include the new test case alert |
java/ql/src/change-notes/2025-11-25-thread-safe-initializers.md |
Documents the enhancement in the release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Raúl Pardo <[email protected]>
Whne a fiels is assigned a safe type in a constructor, that field is not exposed.
yoff
force-pushed
the
java/more-thread-safe-initialisers
branch
from
52296d4 to
efb6a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a field is assigned a safe type in a constructor, that field is not exposed.