Go: fix small issues highlighted by data flow consistency checks

go/Makefile

@@ -54,9 +54,9 @@ ql/lib/go.dbscheme.stats: ql/lib/go.dbscheme build/stats/src.stamp extractor
 	codeql dataset measure -o $@ build/stats/database/db-go
 
 test: all build/testdb/check-upgrade-path
-	codeql test run -j0 ql/test --search-path .. --check-diff-informed --consistency-queries ql/test/consistency --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo) --check-databases --fail-on-trap-errors --check-undefined-labels --check-unused-labels --check-repeated-labels --check-redefined-labels --check-use-before-definition
+	codeql test run -j0 ql/test --search-path .. --check-diff-informed --consistency-queries ql/consistency-queries --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo) --check-databases --fail-on-trap-errors --check-undefined-labels --check-unused-labels --check-repeated-labels --check-redefined-labels --check-use-before-definition
 #	use GOOS=linux because GOOS=darwin GOARCH=386 is no longer supported
-	env GOOS=linux GOARCH=386 codeql$(EXE) test run -j0 ql/test/query-tests/Security/CWE-681 --search-path .. --check-diff-informed --consistency-queries ql/test/consistency --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo)
+	env GOOS=linux GOARCH=386 codeql$(EXE) test run -j0 ql/test/query-tests/Security/CWE-681 --search-path .. --check-diff-informed --consistency-queries ql/consistency-queries --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo)
 	cd extractor; $(BAZEL) test ...
 	bash extractor-smoke-test/test.sh || (echo "Extractor smoke test FAILED"; exit 1)
 

go/ql/lib/change-notes/2025-11-26-unexpected-frontend-errors-query-moved.md

@@ -0,0 +1,4 @@
+---
+category: breaking
+---
+* The query `go/unexpected-frontend-error` has been moved from the `codeql/go-queries` query  to the `codeql-go-consistency-queries` query pack.

go/ql/lib/semmle/go/controlflow/IR.qll

@@ -1588,4 +1588,8 @@
    * in a field/method access, element access, or slice expression.
    */
   EvalImplicitDerefInstruction implicitDerefInstruction(Expr e) { result = MkImplicitDeref(e) }
+
+  Instruction lookThroughImplicitFieldRead(Instruction insn) {
+    result = insn.(ImplicitFieldReadInstruction).getBaseInstruction()
+  }
 }

go/ql/lib/semmle/go/dataflow/SsaImpl.qll

@@ -387,7 +387,8 @@ private module Internal {
       or
       maxSsaRefRank(b1, v) = ssaRefRank(b1, i1, v, _) and
       varBlockStep(v, b1, b2) and
-      ssaRefRank(b2, i2, v, _) = 1
+      ssaRefRank(b2, i2, v, _) = 1 and
+      not (b1 = b2 and i1 = i2)
     }
 
     predicate variableUse(SsaSourceVariable v, IR::Instruction use, ReachableBasicBlock bb, int i) {

go/ql/lib/semmle/go/dataflow/internal/DataFlowImplConsistency.qll

@@ -5,10 +5,25 @@
 
 private import go
 private import DataFlowImplSpecific as Impl
+private import DataFlowUtil
 private import TaintTrackingImplSpecific
 private import codeql.dataflow.internal.DataFlowImplConsistency
 private import semmle.go.dataflow.internal.DataFlowNodes
 
-private module Input implements InputSig<Location, Impl::GoDataFlow> { }
+private module Input implements InputSig<Location, Impl::GoDataFlow> {
+  predicate missingLocationExclude(DataFlow::Node n) {
+    n instanceof DataFlow::GlobalFunctionNode or n instanceof Private::FlowSummaryNode
+  }
+
+  predicate uniqueNodeLocationExclude(DataFlow::Node n) { missingLocationExclude(n) }
+
+  predicate localFlowIsLocalExclude(DataFlow::Node n1, DataFlow::Node n2) {
+    n1 instanceof DataFlow::FunctionNode and simpleLocalFlowStep(n1, n2, _)
+  }
+
+  predicate argHasPostUpdateExclude(DataFlow::ArgumentNode n) {
+    not DataFlow::insnHasPostUpdateNode(n.asInstruction())
+  }
+}
 
 module Consistency = MakeConsistency<Location, Impl::GoDataFlow, GoTaintTracking, Input>;

go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll

@@ -838,7 +838,11 @@ module Public {
       exists(IR::MethodReadInstruction mri |
         ce.getTarget() instanceof Method and
         mri = IR::evalExprInstruction(ce.getCalleeExpr()) and
-        insn = mri.getReceiver()
+        // If a.x is reading a promoted field, and it's equivalent to a.b.c.x,
+        // then mri.getReceiver() will give us the implicit field read a.b.c
+        // and we want to have post-update nodes for a, the implicit field
+        // read a.b and the implicit field read a.b.c.
+        insn = IR::lookThroughImplicitFieldRead*(mri.getReceiver())
       )
     ) and
     mutableType(insn.getResultType())

go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImpl.qll

@@ -384,17 +384,13 @@ module SourceSinkInterpretationInput implements
   }
 
   private DataFlow::Node skipImplicitFieldReads(DataFlow::Node n) {
-    not exists(lookThroughImplicitFieldRead(n)) and result = n
+    not exists(IR::lookThroughImplicitFieldRead(n.asInstruction())) and result = n
     or
-    result = skipImplicitFieldReads(lookThroughImplicitFieldRead(n))
-  }
-
-  private DataFlow::Node lookThroughImplicitFieldRead(DataFlow::Node n) {
-    result.asInstruction() =
-      n.(DataFlow::InstructionNode)
-          .asInstruction()
-          .(IR::ImplicitFieldReadInstruction)
-          .getBaseInstruction()
+    exists(DataFlow::Node mid |
+      mid.asInstruction() = IR::lookThroughImplicitFieldRead(n.asInstruction())
+    |
+      result = skipImplicitFieldReads(mid)
+    )
   }
 
   /** Provides additional sink specification logic. */

go/ql/test/experimental/CWE-203/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,5 @@
+reverseRead
+| timing.go:15:18:15:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| timing.go:28:18:28:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| timing.go:41:18:41:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| timing.go:53:18:53:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-287/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,4 @@
+reverseRead
+| ImproperLdapAuth.go:18:18:18:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| ImproperLdapAuth.go:39:18:39:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| ImproperLdapAuth.go:64:18:64:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-321-V2/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,3 @@
+reverseRead
+| go-jose.v3.go:16:17:16:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| golang-jwt-v5.go:22:17:22:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-369/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,10 @@
+reverseRead
+| DivideByZero.go:10:12:10:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:17:12:17:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:24:12:24:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:31:12:31:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:38:12:38:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:45:12:45:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:54:12:54:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:63:12:63:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| DivideByZero.go:72:12:72:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-522-DecompressionBombs/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,36 @@
+reverseRead
+| test.go:60:15:60:21 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:61:24:61:30 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:62:13:62:19 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:63:17:63:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:64:8:64:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:65:12:65:18 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:66:8:66:14 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:67:12:67:18 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:68:17:68:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:69:21:69:27 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:70:13:70:19 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:71:17:71:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:72:16:72:22 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:73:20:73:26 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:74:7:74:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:75:11:75:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:76:9:76:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:77:13:77:19 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:78:18:78:24 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:79:22:79:28 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:80:5:80:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:81:9:81:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:82:7:82:13 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:83:11:83:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:84:15:84:21 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:85:16:85:22 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:86:20:86:26 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:87:16:87:22 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:88:20:88:26 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:89:17:89:23 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:90:21:90:27 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:91:15:91:21 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:92:19:92:25 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:93:5:93:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:94:9:94:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-807/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,13 @@
+reverseRead
+| SensitiveConditionBypassBad.go:7:5:7:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:16:5:16:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:25:5:25:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:34:5:34:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:41:5:41:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:41:35:41:35 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:49:5:49:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:56:5:56:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:63:5:63:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:70:5:70:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:77:5:77:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:84:5:84:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-840/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,7 @@
+reverseRead
+| ConditionalBypassBad.go:9:5:9:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| ConditionalBypassGood.go:9:5:9:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:9:5:9:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:16:5:16:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:16:41:16:41 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| condition.go:23:5:23:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-918/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,8 @@
+reverseRead
+| builtin.go:115:31:115:31 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| builtin.go:124:32:124:32 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| builtin.go:133:54:133:54 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| builtin.go:142:55:142:55 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| new-tests.go:62:31:62:33 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| new-tests.go:78:18:78:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| new-tests.go:81:37:81:39 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/CWE-942/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,15 @@
+reverseRead
+| CorsMisconfiguration.go:52:14:52:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:59:14:59:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:66:17:66:19 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:74:14:74:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:81:14:81:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:88:14:88:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:101:14:101:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:112:14:112:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:126:15:126:17 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:141:14:141:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:156:14:156:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:170:14:170:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:194:17:194:19 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| CorsMisconfiguration.go:206:14:206:16 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/Unsafe/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,6 @@
+reverseRead
+| WrongUsageOfUnsafe.go:34:40:34:47 | harmless | Origin of readStep is missing a PostUpdateNode. |
+| WrongUsageOfUnsafe.go:55:40:55:47 | harmless | Origin of readStep is missing a PostUpdateNode. |
+| WrongUsageOfUnsafe.go:77:43:77:50 | harmless | Origin of readStep is missing a PostUpdateNode. |
+| WrongUsageOfUnsafe.go:111:47:111:54 | harmless | Origin of readStep is missing a PostUpdateNode. |
+| WrongUsageOfUnsafe.go:211:47:211:54 | harmless | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/experimental/frameworks/CleverGo/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,2 @@
+reverseRead
+| RemoteSources.go:98:9:98:24 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/Types/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,5 @@
+reverseRead
+| pkg1/tst.go:43:6:43:6 | t | Origin of readStep is missing a PostUpdateNode. |
+| pkg1/tst.go:46:6:46:6 | t | Origin of readStep is missing a PostUpdateNode. |
+| pkg1/tst.go:53:6:53:7 | t2 | Origin of readStep is missing a PostUpdateNode. |
+| pkg1/tst.go:55:6:55:7 | t2 | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/concepts/HTTP/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,9 @@
+reverseRead
+| main.go:49:2:49:4 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| main.go:50:2:50:4 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| main.go:58:2:58:5 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| main.go:63:49:63:49 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| server.go:8:6:8:6 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| server.go:9:6:9:6 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| server.go:10:6:10:6 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| server.go:13:6:13:6 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/DefaultTaintSanitizer/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,6 @@
+reverseRead
+| Builtin.go:7:2:7:10 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| Builtin.go:13:2:13:10 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| Builtin.go:22:2:22:10 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| Builtin.go:32:2:32:10 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| Builtin.go:39:2:39:10 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/ExternalTaintFlow/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,4 @@
+reverseRead
+| test.go:90:10:90:15 | taint8 | Origin of readStep is missing a PostUpdateNode. |
+| test.go:104:12:104:18 | taint10 | Origin of readStep is missing a PostUpdateNode. |
+| test.go:150:10:150:14 | slice | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/ExternalValueFlow/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,4 @@
+reverseRead
+| test.go:90:10:90:15 | taint8 | Origin of readStep is missing a PostUpdateNode. |
+| test.go:104:12:104:18 | taint10 | Origin of readStep is missing a PostUpdateNode. |
+| test.go:150:10:150:14 | slice | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/GlobalValueNumbering/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,3 @@
+reverseRead
+| regressions.go:21:3:21:3 | x | Origin of readStep is missing a PostUpdateNode. |
+| regressions.go:22:3:22:3 | y | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/GlobalVariableSideEffects/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,3 @@
+reverseRead
+| globalVariable.go:17:7:17:17 | globalArray | Origin of readStep is missing a PostUpdateNode. |
+| globalVariable.go:18:7:18:17 | globalSlice | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/PostUpdateNodes/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,2 @@
+reverseRead
+| test.go:23:12:23:12 | a | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/SSA/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,3 @@
+reverseRead
+| main.go:97:2:97:8 | wrapper | Origin of readStep is missing a PostUpdateNode. |
+| main.go:117:2:117:2 | p | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/dataflow/ThreatModels/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,2 @@
+reverseRead
+| test.go:32:11:32:11 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/frameworks/Afero/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,2 @@
+reverseRead
+| test.go:19:14:19:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/frameworks/Beego/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,16 @@
+reverseRead
+| test.go:142:3:142:9 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:143:3:143:9 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:143:23:143:29 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:208:18:208:20 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:208:18:208:28 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:229:21:229:25 | files | Origin of readStep is missing a PostUpdateNode. |
+| test.go:259:2:259:2 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:270:37:270:37 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:283:44:283:48 | files | Origin of readStep is missing a PostUpdateNode. |
+| test.go:297:51:297:62 | genericFiles | Origin of readStep is missing a PostUpdateNode. |
+| test.go:298:54:298:62 | untainted | Origin of readStep is missing a PostUpdateNode. |
+| test.go:317:13:317:15 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:318:20:318:22 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:324:17:324:19 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |
+| test.go:324:17:324:25 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/frameworks/BeegoOrm/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,2 @@
+reverseRead
+| test.go:110:20:110:23 | objs | Origin of readStep is missing a PostUpdateNode. |

go/ql/test/library-tests/semmle/go/frameworks/Chi/CONSISTENCY/DataFlowConsistency.expected

@@ -0,0 +1,2 @@
+reverseRead
+| test.go:13:12:13:12 | implicit dereference | Origin of readStep is missing a PostUpdateNode. |